Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use concurrent hash map to avoid potential infinite stall #558

Merged
merged 3 commits into from
Nov 14, 2024

Conversation

strangesource
Copy link
Contributor

@strangesource strangesource commented Nov 13, 2024

Description

An infinite stall was reported when playing back DRM content with preprocessHttpRequest network config configured.
preprocessHttpRequest is an API that is being called on multiple threads and hence must be treated in a thread safe way. However, the map used for the in-flight preprocessing is NOT thread safe and hence could cause infinite blocking preprocessing calls.

Changes

  • Use concurrent hash map to avoid infinite stalls
  • Add error log in case a completer can not be found as this should never happen

Checklist

  • 🗒 CHANGELOG entry

@strangesource strangesource self-assigned this Nov 13, 2024
@strangesource strangesource marked this pull request as ready for review November 13, 2024 13:35
@strangesource strangesource requested a review from a team as a code owner November 13, 2024 13:35
@strangesource strangesource requested review from zigavehovec and matamegger and removed request for a team November 13, 2024 13:36
@strangesource strangesource merged commit 0735f55 into development Nov 14, 2024
3 checks passed
@strangesource strangesource deleted the PRN-145/fix-potential-infinite-stall branch November 14, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants