Exception are now always caught, remove compile time check #345
+48
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krocard
changed the title
This was referenced Dec 6, 2023
Base automatically changed from
PRN-74/refactor--improve-null-safety
to
development
December 7, 2023 08:36
zigavehovec
approved these changes
Dec 7, 2023
android/src/main/java/com/bitmovin/player/reactnative/BitmovinBaseModule.kt
Outdated
Show resolved
Hide resolved
android/src/main/java/com/bitmovin/player/reactnative/BitmovinBaseModule.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Žiga Vehovec <[email protected]>
matamegger
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem (PRN-92)
RejectPromiseOnExceptionBlockwas introduced as a compile time way of throwing with a guaranty that the exception would be caught and the promise rejected.Now that all the code has been migrated to the safer
run*AndRejectOnException, the complexity ofRejectPromiseOnExceptionBlockis no longer warrantied.Changes
Remove
RejectPromiseOnExceptionBlock, which allows some simplification as it was shadowing the receiver in some cases.📚 Other PRs for this issue