Fix Picture in Picture sample screen layout on tvOS #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolandkakonyi
force-pushed
the
fix-PiP-sample-for-tvOS
branch
from
f0680b3 to
4da61e3
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Found that on tvOS playback can not be controlled when using the Picture in Picture sample screen.
This is due to the player not taking the whole screen. This is a feature from Apple to not have controls for inline players shown.
Changes
Replaced
SafeAreaViewfor tvOS withViewworks now.Note: I tried changing
edgesproperty to[]but that didn't work as expected on tvOS simulator.Checklist
CHANGELOGentry