Fix onEvent never triggered on PlayerView on Android
#327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolandkakonyi
commented
Nov 23, 2023
| @@ -25,7 +25,6 @@ import com.facebook.react.uimanager.events.RCTEventEmitter | |||
| import kotlin.reflect.KClass | |||
|
|
|||
| private val EVENT_CLASS_TO_REACT_NATIVE_NAME_MAPPING = mapOf( | |||
| PlayerEvent::class to "event", | |||
There was a problem hiding this comment.
This did nothing, so I removed it.
There was a problem hiding this comment.
This is a bit of a flaw in our event emitter. From a typing perspective one would expect that this works - but it doesn't.
There was a problem hiding this comment.
Thanks for the clarification! It confused me too!
strangesource
approved these changes
Nov 24, 2023
| @@ -25,7 +25,6 @@ import com.facebook.react.uimanager.events.RCTEventEmitter | |||
| import kotlin.reflect.KClass | |||
|
|
|||
| private val EVENT_CLASS_TO_REACT_NATIVE_NAME_MAPPING = mapOf( | |||
| PlayerEvent::class to "event", | |||
There was a problem hiding this comment.
This is a bit of a flaw in our event emitter. From a typing perspective one would expect that this works - but it doesn't.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Found that
<PlayerView onEvent={}>callback was never triggered on Android.This would simplify implementing use cases when looking at all events, like for a player testing framework's event expectation system.
Changes
Turned out that this is not supported out of the box on Android.
I have implemented it on the React Native side, within
RNPlayerView.Events coming from the player are now emitted through
onEventas well.I didn't include view events as we don't support that on any of the native platforms.
For manual testing, add this to any
<PlayerView />:Checklist
CHANGELOGentry