Apply ktlint formatting #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolandkakonyi
approved these changes
Oct 9, 2023
matamegger
approved these changes
Oct 9, 2023
Comment on lines
+126
to
+127
| OfflineOptionEntryState.Failed, | ||
| -> { |
There was a problem hiding this comment.
I agree. I guess this is because of trailing commas rule: https://pinterest.github.io/ktlint/0.49.1/rules/configuration-ktlint/#trailing-comma-on-call-site
In the newest version of ktlint you either have the option to always have trailing commas or never. I decided to go with always, since it makes sense 99% of the time.
I'm not sure we can improve on that.
Comment on lines
284
to
285
| private fun drmModule(): DrmModule? = | ||
| context.getNativeModule(DrmModule::class.java) | ||
| context.getNativeModule(DrmModule::class.java) |
There was a problem hiding this comment.
NIT: Would fit into one line I think.
There was a problem hiding this comment.
Good point, I missed that.
bc9fa39
Comment on lines
290
to
291
| private fun uiManager(): UIManagerModule? = | ||
| context.getNativeModule(UIManagerModule::class.java) | ||
| context.getNativeModule(UIManagerModule::class.java) |
There was a problem hiding this comment.
NIT: Would fit into one line I think.
There was a problem hiding this comment.
Good point, I missed that.
bc9fa39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Kotlin code isn't properly formatted.
Changes
This PR applies ktlint formatting introduced in #276.
Checklist
CHANGELOGentry