Skip to content

Commit

Permalink
Merge pull request #328 from bitmovin/fix-onEvent-payload-on-iOS
Browse files Browse the repository at this point in the history
Fix incomplete `onEvent` payload on iOS
  • Loading branch information
rolandkakonyi authored Nov 24, 2023
2 parents 9b447c9 + b4fd7ac commit f3d6f7f
Show file tree
Hide file tree
Showing 6 changed files with 270 additions and 217 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
### Fixed

- Android: `onEvent` callback not being called on `PlayerView`
- iOS: `onEvent` on iOS has incomplete payload information

## [0.14.1] (2023-11-16)

Expand Down
9 changes: 9 additions & 0 deletions ios/DefaultJsonConvertibleEvent.swift
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
import BitmovinPlayer

/// Used when the event has no additional data
internal protocol DefaultJsonConvertibleEvent: JsonConvertible {}
internal extension DefaultJsonConvertibleEvent where Self: Event {
func toJSON() -> [AnyHashable: Any] {
toEventJSON { [:] }
}
}
Loading

0 comments on commit f3d6f7f

Please sign in to comment.