Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not send warning events to conviva outside of active conviva session #82

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Do not send warning events to conviva outside of active conviva session #82

merged 2 commits into from
Sep 4, 2024

Conversation

strangesource
Copy link
Contributor

Problem

PlayerEvent.Warning and SourceEvent.Warning can happen outside of an active Conviva session. This can result in invalid reporting.

Changes

  • Only relay warning events to Conviva if there is an active Conviva session
  • Update Bitmovin Player to the latest version

@strangesource strangesource self-assigned this Sep 4, 2024
testcenter
testcenter approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@testcenter testcenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@strangesource strangesource merged commit 77a0b5f into develop Sep 4, 2024
3 checks passed
@strangesource strangesource deleted the fix-touchstone-error-on-warning-without-active-conviva-session branch September 4, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@testcenter testcenter testcenter approved these changes

Assignees

@strangesource strangesource

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@strangesource @testcenter