Merge pull request #81 from bitmovin/feature/remove-testing-initializers

Remove unintentionally public initializers
bitmovin · Aug 26, 2024 · 1c6d2f5 · 1c6d2f5
2 parents 96e2ce8 + bc1c69f
commit 1c6d2f5
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 33 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,9 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/)
 and this project adheres to [Semantic Versioning](http://semver.org/).
 
+## [Unreleased]
+### Removed
+- Unintentionally public initializers from `ConvivaAnalyticsIntegration` which were not intended to be public and only meant for testing
 
 ## 2.6.0 - 2024-08-13
 ### Added

diff --git a/conviva/src/main/java/com/bitmovin/analytics/conviva/ConvivaAnalyticsIntegration.java b/conviva/src/main/java/com/bitmovin/analytics/conviva/ConvivaAnalyticsIntegration.java
@@ -57,42 +57,23 @@ public ConvivaAnalyticsIntegration(Player player, String customerKey, Context co
         this(player, customerKey, context, new ConvivaConfig());
     }
 
-    public ConvivaAnalyticsIntegration(Player player,
-                                       String customerKey,
-                                       Context context,
-                                       ConvivaConfig config) {
-        this(player, customerKey, context, config, null);
-    }
-
-    public ConvivaAnalyticsIntegration(Player player,
-                                       String customerKey,
-                                       Context context,
-                                       ConvivaConfig config,
-                                       ConvivaVideoAnalytics videoAnalytics
+    public ConvivaAnalyticsIntegration(
+        Player player,
+        String customerKey,
+        Context context,
+        ConvivaConfig config
     ) {
-        this(player, customerKey, context, config, videoAnalytics, null);
+        this(player, customerKey, context, config, null, null, null);
     }
 
-    public ConvivaAnalyticsIntegration(Player player,
-                                       String customerKey,
-                                       Context context,
-                                       ConvivaConfig config,
-                                       ConvivaVideoAnalytics videoAnalytics,
-                                       ConvivaAdAnalytics adAnalytics
-    ) {
-        this(player, customerKey, context, config, videoAnalytics, adAnalytics, null);
-    }
-
-    /**
-     * For testing purposes only.
-     */
-    ConvivaAnalyticsIntegration(Player player,
-                                String customerKey,
-                                Context context,
-                                ConvivaConfig config,
-                                ConvivaVideoAnalytics videoAnalytics,
-                                ConvivaAdAnalytics adAnalytics,
-                                DefaultSsaiApi ssai
+    ConvivaAnalyticsIntegration(
+        Player player,
+        String customerKey,
+        Context context,
+        ConvivaConfig config,
+        ConvivaVideoAnalytics videoAnalytics,
+        ConvivaAdAnalytics adAnalytics,
+        DefaultSsaiApi ssai
     ) {
         this.bitmovinPlayer = player;
         this.playerHelper = new BitmovinPlayerHelper(player);