Merge branch 'main' into feat/increase-minute-interval-limit

bitmovin · Jul 25, 2024 · f4594ac · f4594ac
2 parents 2a5a1ea + 18b3cc1
commit f4594ac
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,10 @@
 
 - different query start times with multiple queries due to mutating of grafana start time
 
+### Added
+
+- Default Percentile Value when percentile metric is selected
+
 ## 1.1.1
 
 ### Added

diff --git a/src/components/QueryEditor.tsx b/src/components/QueryEditor.tsx
@@ -69,7 +69,17 @@ export function QueryEditor(props: Props) {
   };
 
   const handleAggregationChange = (item: SelectableValue) => {
-    props.onChange({ ...query, metric: item.value });
+    // set a default value when percentile is selected and delete percentileValue when percentile is deselected
+    // to not pollute the dashboard.json file
+    let percentile = undefined;
+    if (item.value === 'percentile' && percentileValue == null) {
+      setPercentileValue(95);
+      percentile = 95;
+    } else {
+      setPercentileValue(undefined);
+    }
+
+    props.onChange({ ...query, metric: item.value, percentileValue: percentile });
     props.onRunQuery();
   };