Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] AttachPdfViewHelper #228

Merged
merged 2 commits into from
Aug 11, 2023
Merged

[FEATURE] AttachPdfViewHelper #228

merged 2 commits into from
Aug 11, 2023

Conversation

georgringer
Copy link
Contributor

Resolves: #227

@maechler maechler self-assigned this Aug 11, 2023
maechler
maechler approved these changes Aug 11, 2023
View reviewed changes
Copy link
Member

@maechler maechler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you very much! I might change the naming and API slightly, add docs and tests before the next release, but the basic functionality of the ViewHelper will stay the same.

@maechler maechler merged commit cd0390a into bithost-gmbh:main Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maechler maechler maechler approved these changes

Assignees

@maechler maechler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ViewHelper to attach another PDF
2 participants
@georgringer @maechler