Merge pull request #109 from bithost-gmbh/bugfix/107-no-entries-found

avoid no entries found class when opening the select panel
bithost-gmbh · Feb 28, 2019 · fa670ac · fa670ac
2 parents 84f20b1 + df72b86
commit fa670ac
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,11 @@
 # Changelog
 
+## 1.5.3
+* Bugfix: Avoid space when opening select panel after previously showing "no entries found" message when placing `<ngx-mat-select-search>` inside a `<mat-option>` element
+  [#107](https://github.com/bithost-gmbh/ngx-mat-select-search/issues/107)
+
+  Thanks to @aroblu94 for reporting
+
 ## 1.5.2
 * Bugfix: Show "no entries found" message when placing `<ngx-mat-select-search>` inside a `<mat-option>` element
   [#101](https://github.com/bithost-gmbh/ngx-mat-select-search/issues/101)

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "ngx-mat-select-search",
   "description": "Library that provides an angular component providing an input field for searching / filtering MatSelect options of the Angular Material library.",
-  "version": "1.5.2",
+  "version": "1.5.3",
   "license": "MIT",
   "scripts": {
     "ng": "ng",

diff --git a/src/app/mat-select-search/mat-select-search.component.ts b/src/app/mat-select-search/mat-select-search.component.ts
@@ -172,7 +172,7 @@ export class MatSelectSearchComponent implements OnInit, OnDestroy, AfterViewIni
 
 
   constructor(@Inject(MatSelect) public matSelect: MatSelect,
-              private changeDetectorRef: ChangeDetectorRef,
+              public changeDetectorRef: ChangeDetectorRef,
               @Optional() @Inject(MatOption) public matOption: MatOption = null) {
 
 
@@ -359,6 +359,10 @@ export class MatSelectSearchComponent implements OnInit, OnDestroy, AfterViewIni
     }
     this.searchSelectInput.nativeElement.value = '';
     this.onInputChange('');
+    if (this.matOption && !focus) {
+      // remove no entries found class on mat option
+      this.matOption._getHostElement().classList.remove('mat-select-search-no-entries-found');
+    }
     if (focus) {
       this._focus();
     }