Add signature verification endpoints #209
Open
+234
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsyaasir
force-pushed
the
add-signature-verification
branch
from
fd96ce4 to
4b6ae7a
Compare
itsyaasir
force-pushed
the
add-signature-verification
branch
from
55159ac to
17646bb
Compare
…ith-inspect feat: update access control methods to include 'admin_' prefix
ufoscout
requested changes
Nov 27, 2024
ufoscout
approved these changes
Nov 28, 2024
veeso
approved these changes
Nov 29, 2024
F3kilo
approved these changes
Nov 29, 2024
…gnatureVerificationCanisterInitData
…onCanisterInitData
…ed in EvmCanisterClient
ufoscout
requested changes
Dec 10, 2024
| @@ -844,4 +844,14 @@ impl<C: CanisterClient> EvmCanisterClient<C> { | |||
| ) -> CanisterClientResult<Result<()>> { | |||
| self.client.update("revert_to_block", (args,)).await | |||
| } | |||
|
|
|||
| /// Receive a batch of Transactions and append them to the blockchain. | |||
| pub async fn receive_transactions_unchecked( | |||
There was a problem hiding this comment.
This is to send, not to receive
There was a problem hiding this comment.
It is to recieve transactions tho
There was a problem hiding this comment.
No, the client sends transactions, for example, the Ethereum endpoint to send a TX is indeed called SENDRawTransaction. If you don't like send, you can find a synonym like push or add but not receive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue ticket
Issue ticket link: <>
Checklist before requesting a review
Code conventions
Security
Testing
canister_call!macro