Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flake.nix: use temurin-bin-23 instead of jdk23 #104

Merged
merged 1 commit into from
Dec 2, 2024
Merged

flake.nix: use temurin-bin-23 instead of jdk23 #104

merged 1 commit into from
Dec 2, 2024
+1 −1

Conversation

msgilligan
Copy link
Member

This is a workaround for Issue #93. (But we should switch back to jdk23 which is built from source, when it or gradle is fixed)

This is a child of PR #103 (We should update to latest Nixpkgs versions as that is what I have been testing with)

@msgilligan msgilligan marked this pull request as ready for review December 2, 2024 13:34
@msgilligan msgilligan force-pushed the msgilligan/nix-use-temurin-bin-23 branch from 51221c9 to 44e3b6c Compare December 2, 2024 15:09
schildbach
schildbach approved these changes Dec 2, 2024
View reviewed changes
Copy link
Member

@schildbach schildbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I must admit that I would normally just not update to everything-latest if that means I'd have to deviate from a "core value" (use packages built from source), but I'll approve the change anyway because I see no serious issue with the change itself.

@msgilligan
Copy link
Member Author

I must admit that I would normally just not update to everything-latest

Unfortunately, Nix has removed the jdk22 package as JDK 22 is unsupported (by Oracle/OpenJDK), and we require JDK 22 or later for FFM ("Panama"). So we are forced to upgrade to JDK 23 (on Nixpkgs) and need to make it work somehow.

Anyway, thanks for your approval.

@msgilligan msgilligan merged commit 6686417 into master Dec 2, 2024
6 checks passed
@msgilligan msgilligan deleted the msgilligan/nix-use-temurin-bin-23 branch December 2, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schildbach schildbach schildbach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msgilligan @schildbach