Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't call update during paint #374

Merged
merged 1 commit into from
Dec 2, 2023
Merged

Don't call update during paint #374

merged 1 commit into from
Dec 2, 2023

Conversation

promag
Copy link
Contributor

@promag promag commented Nov 30, 2023

No description provided.

jarolrod
jarolrod approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@jarolrod jarolrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK caa0f4a

Confirmed this line is unnecessary

@jarolrod jarolrod added the enhancement New feature or request label Nov 30, 2023
johnny9
johnny9 approved these changes Dec 2, 2023
View reviewed changes
Copy link
Contributor

@johnny9 johnny9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK c54c973

@hebasto hebasto changed the title qml: dont call update during paint Don't call update during paint Dec 2, 2023
@hebasto hebasto merged commit 97fe0b7 into bitcoin-core:main Dec 2, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarolrod jarolrod jarolrod approved these changes

@johnny9 johnny9 johnny9 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@promag @johnny9 @jarolrod @hebasto