Skip to content

Commit

Permalink
Merge #420: Wallet creation flow font weight and color tweaks
Browse files Browse the repository at this point in the history
c753d16 Wallet creation flow font weight and color tweaks (GBKS)

Pull request description:

  There are some very minor implementation discrepancies from the design in the wallet creation flow. The font weights for several titles are regular, but should be semi-bold (see all the other screens in the onboarding flow for examples). Two divider lines are neutral 7, but should be the neutral 4 color.

  See the following image with screenshots for the comparison. Top row shows the before, the bottom row shows the after. The second column is where the two divider line colors were adjusted. The other columns is where the font weight of the header was adjusted.

  ![image](https://github.com/user-attachments/assets/173955a9-438a-43b0-b5f7-9b23955b7286)

  This is my first PR for this project, let me know what I am doing wrong.

ACKs for top commit:
  MarnixCroes:
    lgtm ACK c753d16
  pablomartin4btc:
    utACK c753d16

Tree-SHA512: a26163620eb37712fb72811d2ce363bad025a2884d30abf03fc96e32b7fed04486f75be01f52120d42d8f0bf89aeb8551783b17bef75004af692fe742275a885
  • Loading branch information
hebasto committed Sep 2, 2024
2 parents e7bea2d + c753d16 commit 48bc2c8
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 2 deletions.
1 change: 1 addition & 0 deletions src/qml/pages/wallet/AddWallet.qml
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ StackView {
Layout.leftMargin: 20
Layout.rightMargin: 20
header: qsTr("Add a wallet")
headerBold: true
description: qsTr("In this early stage of development, only wallet.dat files are supported.")
}

Expand Down
1 change: 1 addition & 0 deletions src/qml/pages/wallet/CreateBackup.qml
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ Page {
Layout.leftMargin: 20
Layout.rightMargin: 20
header: qsTr("Back up your wallet")
headerBold: true
description: qsTr("Your wallet is a file stored on your hard disk.\nTo prevent accidental loss, it is recommended you keep a copy of your wallet file in a secure place, like a dedicated USB Drive.")
}

Expand Down
1 change: 1 addition & 0 deletions src/qml/pages/wallet/CreateConfirm.qml
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ Page {
Layout.leftMargin: 20
Layout.rightMargin: 20
header: qsTr("Your wallet has been created")
headerBold: true
description: qsTr("It is good practice to make a small test transaction before you actively use this wallet for larger amounts.")
}

Expand Down
4 changes: 2 additions & 2 deletions src/qml/pages/wallet/CreateIntro.qml
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ Page {
Layout.leftMargin: 20
Layout.rightMargin: 20
Layout.fillWidth: true
color: Theme.color.neutral7
color: Theme.color.neutral4
}

CoreText {
Expand All @@ -88,7 +88,7 @@ Page {
Layout.leftMargin: 20
Layout.rightMargin: 20
Layout.fillWidth: true
color: Theme.color.neutral7
color: Theme.color.neutral4
}

CoreText {
Expand Down
1 change: 1 addition & 0 deletions src/qml/pages/wallet/CreateName.qml
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ Page {
Layout.leftMargin: 20
Layout.rightMargin: 20
header: qsTr("Choose a wallet name")
headerBold: true
}

CoreTextField {
Expand Down
1 change: 1 addition & 0 deletions src/qml/pages/wallet/CreatePassword.qml
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ Page {
Layout.leftMargin: 20
Layout.rightMargin: 20
header: qsTr("Choose a password")
headerBold: true
description: qsTr("It is recommended to set a password to protect your wallet file from unwanted access from others.")
}

Expand Down

0 comments on commit 48bc2c8

Please sign in to comment.