Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #94

Merged
merged 7 commits into from
Apr 12, 2023
Merged

Fix CI #94

merged 7 commits into from
Apr 12, 2023

Conversation

Flova
Copy link
Member

@Flova Flova commented Apr 11, 2023

Proposed changes

  • Fix CI

yoeo/utils/loss.py Outdated Show resolved Hide resolved
yoeo/utils/loss.py Outdated Show resolved Hide resolved
yoeo/utils/loss.py Show resolved Hide resolved
@jaagut jaagut mentioned this pull request Apr 11, 2023
4 tasks
@jaagut
Copy link
Member

jaagut commented Apr 11, 2023

Also, we could consider these ideas from the original PR:
#44 (comment)

Co-authored-by: Jan Gutsche <[email protected]>
@Flova
Copy link
Member Author

Flova commented Apr 12, 2023

They are nice improvements, but not straight forward, so we should maybe do it in another PR

@jaagut
Copy link
Member

jaagut commented Apr 12, 2023

I have converted my comment mentioned earlier to a new issue #96

@Flova
Copy link
Member Author

Flova commented Apr 12, 2023

Okay 👍

@jaagut jaagut merged commit 4d3346d into main Apr 12, 2023
@jaagut jaagut deleted the fix/ci branch April 12, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants