Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compound id bug #873

Merged
merged 6 commits into from
Jun 5, 2024
Merged

Compound id bug #873

merged 6 commits into from
Jun 5, 2024

Conversation

bkieft-usa
Copy link
Collaborator

Three main changes were implemented to add more functionality to the targeted workflow:

  1. Calculation of total score (from -1 to 3) for each compound and assigning an MSI Level quality was pulled into its own function
  2. If only one reference-matching MSMS fragment ion is detected for a given compound, it will check whether the fragement is the precursor or not; if it is, it will give that compound an MSMS score of 0 and MSMS quality of 0, while if it is not, it will keep the MSMS scored calculated with matchMS and give the corresponding MSI Level. It will also print a note into the ms2_notes of the compound id sheet when a single fragment ion is found and tell the reviewer whether it's the precursor or not.
  3. New logger statements print to the notebook console warning when only single fragment ions are detected.

@bkieft-usa bkieft-usa self-assigned this Jun 4, 2024
@bkieft-usa bkieft-usa merged commit fbaa133 into main Jun 5, 2024
5 of 6 checks passed
@bkieft-usa bkieft-usa deleted the compound_id_bug branch June 5, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant