-
-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(linter): implement noLowerCaseEnum #4031
base: main
Are you sure you want to change the base?
Conversation
CodSpeed Performance ReportMerging #4031 will not alter performanceComparing Summary
|
I think could be handled by https://biomejs.dev/linter/rules/use-naming-convention/#typescript-enum-names ? If you are planning on working issue yourself, you can open straight up and someone will assign you, but you do not need to wait for that. Though discussion can help to make sure you are going into right direction. If you do not plan working on it but want it implemented:
|
mmh i have no idea for the ts enums 🤔 even if those are Graphql enums? 🤔 and if you want differents rules between gql & ts? |
crates/biome_graphql_analyze/src/lint/nursery/no_lower_case_enum.rs
Outdated
Show resolved
Hide resolved
crates/biome_graphql_analyze/src/lint/nursery/no_lower_case_enum.rs
Outdated
Show resolved
Hide resolved
crates/biome_graphql_analyze/src/lint/nursery/no_lower_case_enum.rs
Outdated
Show resolved
Hide resolved
c7e2d6e
to
cd3ebb6
Compare
I'll defer to somebody else for what the name for this rule should be. There should also be a changelog entry for this. |
cd3ebb6
to
fc8a858
Compare
thx for the quick review, I've added the changelog entry |
I think originally the idea was that multiple languages can have the same rule. Like for example json language has |
fc8a858
to
ac5384e
Compare
Summary
please be indulgent, i'm a very noob in rust /o\
also there are no linked issue bc i'm not sure which one i should create.
Test Plan
see tests