Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eager fixes for distributed execution #558

Open
wants to merge 2 commits into
base: future
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion compiler/dspash/ir_helper.py
Original file line number Diff line number Diff line change
@@ -71,7 +71,7 @@ def to_shell_file(graph: IR, args) -> str:
# Set DFGNode next id to not clash with already existing ids
# TODO: ideally we should get the next_id from the graph object
# to avoid conflicts across parallel processes
DFGNode.next_id = max(DFGNode.next_id , graph.nodes.keys()+ 1)
DFGNode.next_id = max(DFGNode.next_id , max(graph.nodes.keys()) + 1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we do that in general? Outside of this if statement?

graph = pash_runtime.add_eager_nodes(graph, args.dgsh_tee)

script = to_shell(graph, args)