-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor fixes around annotations #305
base: main
Are you sure you want to change the base?
Conversation
OS:ubuntu-18.04 |
OS:ubuntu-20.04 |
I think that we should not merge this before we investigate what are the new failing test cases. I might have some time to take a look. If we want to merge these (and other changes) faster (without making sure that correctness tests pass) we can use the |
@angelhof Agreed! BTW we think we know why tests are failing, and we're working to fix them. |
"stdin-hyphen", | ||
"empty-args-stdin" | ||
], | ||
"short-long": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not yet supported by PaSh. We can open an issue or add a test with a long version of one of these flags and use that in a PR to implement that.
], | ||
"options": [ | ||
"stdin-hyphen", | ||
"empty-args-stdin" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similarly, this is not implemented at the moment (and is very crucial for all the commands that read from stdin if they have no arguments). In its current form, the annotation leads to test failures because uses of cut
that read from stdin
are not supported (that is why previously cut
's annotation only reads from stdin).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably the reason why tests fail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK there are probably multiple reasons why the tests are failing:P
No description provided.