-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/bmspt 283 delegate methods #23
Open
BalintBende
wants to merge
30
commits into
develop
Choose a base branch
from
feature/BMSPT-283-delegate-methods
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
b73d91a
[BMSPT-283] Added delegate methods next to in memory bcf representation.
eriadam 18d09f4
[BMSPT-283] added bcf builder delegate
BalintBende 6db9ad0
[NOISSUE] fixed bug, entries in unordered list, added file builder test
BalintBende dd34edc
[NOISSUE] updated dotsettings
BalintBende 7bec3fe
[NOISSUE] fixed comments
BalintBende 1d65441
[BMSPT-289] fixed location and direction instance creation in bitmap,…
BalintBende f5780a9
[BMSPT-289] fixed location and direction instance creation in bitmap,…
BalintBende 4ec8849
[BMSPT-289] added viewpoint builder, format, unit tests
BalintBende 78be45f
[BMSPT-291] fixed possible null pointer issues
BalintBende eed0a80
Fixing incomplete byte read for images
eriadam 639cd55
lint
eriadam 6e7b798
Reorganised tests to separate the delegate pattern tests
eriadam cd29e7b
[BMSPT-292] organized schema xsd resources
BalintBende ac7add0
[BMSPT-292] added nullable types bcf 2.1
BalintBende eba078d
[BMSPT-292] added nullable types bcf 3.0
BalintBende d50ac3c
[BMSPT-292] fixed builder nullable inputs, fixed unit tests
BalintBende 21e82f9
Feature/bmspt 275 bcfzip with stream (#17)
BalintBende aec1973
Fixing merge conflict
386aa93
[BMSPT-293] Added cancellation token to Converter stream operations. …
eriadam 12a18d8
extended bcf builder with new functions, project, document, formating…
BalintBende 4df1e0b
Updated Readme files
BalintBende c9767eb
[NOISSUE] fixed viewpoint extension in FileWriter
BalintBende 81ecdb0
[BMSPT-283] Added delegate methods next to in memory bcf representation.
eriadam 2da6f9f
[BMSPT-283] on markup created
BalintBende f7c3488
[BMSPT-283] builder delegate
BalintBende 6957093
Merge branch 'develop' of github.com:bimspot/bcf-converter into featu…
BalintBende 9b8583f
[BMSPT-283] builder delegate draft
BalintBende 6e81181
[BMSPT-283] fixed BCF21 version, added proces stream fns to bcf build…
BalintBende 93499c1
[BMSPT-283] deleted bcf21 process stream test
BalintBende 7c099c7
[BMSPT-283] added nullable Orthogonal and Perspective camera in Visinfo
BalintBende File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
using BcfToolkit.Model.Interfaces; | ||
|
||
namespace BcfToolkit.Builder.Interfaces; | ||
|
||
public interface IBcfBuilderDelegate { | ||
public delegate void OnMarkupCreated<in TMarkup>(TMarkup markup) | ||
where TMarkup : IMarkup; | ||
|
||
public delegate void OnProjectCreated<in TProjectInfo>( | ||
TProjectInfo projectInfo) | ||
where TProjectInfo : IProject; | ||
|
||
public delegate void OnExtensionsCreated<in TExtensions>( | ||
TExtensions extensions) | ||
where TExtensions : IExtensions; | ||
|
||
public delegate void OnDocumentCreated<in TDocumentInfo>( | ||
TDocumentInfo documentInfo) | ||
where TDocumentInfo : IDocumentInfo; | ||
|
||
public OnMarkupCreated<IMarkup> MarkupCreated { get; } | ||
public OnExtensionsCreated<IExtensions> ExtensionsCreated { get; } | ||
public OnProjectCreated<IProject> ProjectCreated { get; } | ||
public OnDocumentCreated<IDocumentInfo> DocumentCreatedCreated { get; } | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should the commented-out parts remain for future use? |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls consider the following solutions for the "return Task.Completed case":
if (_delegate is null) {
throw new InvalidOperationException("IBcfBuilderDelegate is not set.");
}