Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/bmspt 299 super bcf file #22

Merged
merged 3 commits into from
Sep 9, 2024

Conversation

DanielLepold
Copy link
Contributor

Pull Request Template

Description

The pr includes the following changes:

  • Generation of super bcf files for 2.1 and 3.0 versions.
  • Extension method extensions.

Type Of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality
    to not work as expected)
  • This change requires a documentation update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no API changes)
  • CI/Build related changes (so that Github is happy)
  • Dockerfile related changes
  • Documentation content changes
  • Tests (extended coverage or fixing existing tests)
  • Updated dependencies

API Changes

  • Introducing a new method or property
  • Updating the API
  • Deprecating methods or properties

Environment (Docker)

  • Adding a new environment variable
  • Updating the production container

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have checked my code and corrected any misspellings
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have tested my code in the local docker-compose environment
  • My feature branch builds on Github

Copy link

github-actions bot commented Sep 3, 2024

Test Results

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 79195aa. ± Comparison against base commit 846135b.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@BalintBende BalintBende left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fasza! Please check my comments.

src/tests/Builder/Bcf21/SuperBcfFile.cs Outdated Show resolved Hide resolved
src/tests/Builder/Bcf21/SuperBcfFile.cs Outdated Show resolved Hide resolved
src/tests/Builder/Bcf21/SuperBcfFile.cs Outdated Show resolved Hide resolved
src/tests/Builder/Bcf21/SuperBcfFile.cs Outdated Show resolved Hide resolved
src/tests/Builder/Bcf21/SuperBcfFile.cs Outdated Show resolved Hide resolved
src/tests/Builder/Bcf30/SuperBcfFile.cs Outdated Show resolved Hide resolved
src/tests/Builder/Bcf30/SuperBcfFile.cs Outdated Show resolved Hide resolved
src/tests/Builder/Bcf30/SuperBcfFile.cs Show resolved Hide resolved
src/tests/Builder/Bcf30/SuperBcfFile.cs Show resolved Hide resolved
src/tests/Builder/Bcf30/SuperBcfFile.cs Outdated Show resolved Hide resolved
@DanielLepold DanielLepold merged commit 3a87ef2 into develop Sep 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants