Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BMSPT-293] Added cancellation token to Converter stream operations. #18

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

eriadam
Copy link
Member

@eriadam eriadam commented Jun 13, 2024

The PR adds cancellation token to Converter stream operations.

Type Of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality
    to not work as expected)
  • This change requires a documentation update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no API changes)
  • CI/Build related changes (so that Github is happy)
  • Dockerfile related changes
  • Documentation content changes
  • Tests (extended coverage or fixing existing tests)
  • Updated dependencies

API Changes

  • Introducing a new method or property
  • Updating the API
  • Deprecating methods or properties

Environment (Docker)

  • Adding a new environment variable
  • Updating the production container

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have checked my code and corrected any misspellings
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have tested my code in the local docker-compose environment
  • My feature branch builds on Github

@eriadam eriadam requested a review from BalintBende June 13, 2024 16:26

This comment has been minimized.

This comment has been minimized.

1 similar comment

This comment has been minimized.

@BalintBende BalintBende merged commit d0e6aac into develop Jun 17, 2024
3 checks passed
@BalintBende BalintBende deleted the feature/BMSPT-293-cancellation-token branch June 17, 2024 13:56
Copy link

Unit Test Results

0 files  ±0  0 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit d0e6aac. ± Comparison against base commit 7e13bde.

BalintBende pushed a commit that referenced this pull request Jun 25, 2024
…18)

* [BMSPT-293] Added cancellation token to Converter stream operations.

* [BMSPT-293] Added cancellation token to Converter stream operations.

---------

Co-authored-by: Adam Eri <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants