Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/bmspt 275 bcfzip with stream #17

Merged
merged 6 commits into from
Jun 13, 2024

Conversation

BalintBende
Copy link
Contributor

@BalintBende BalintBende commented Jun 12, 2024

Pull Request Template

Description

PR includes the new method of the file writer. Now the toolkit can either either saves the xml to the target file or creates a zip entry from a memory stream.

The user can call the ToBcfStream function with the input param called writeToTmp. Based on that the file writer will handle the zip archive as it mentioned above.

Fixes

Type Of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality
    to not work as expected)
  • This change requires a documentation update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no API changes)
  • CI/Build related changes (so that Github is happy)
  • Dockerfile related changes
  • Documentation content changes
  • Tests (extended coverage or fixing existing tests)
  • Updated dependencies

API Changes

  • Introducing a new method or property
  • Updating the API
  • Deprecating methods or properties

Environment (Docker)

  • Adding a new environment variable
  • Updating the production container

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have checked my code and corrected any misspellings
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have tested my code in the local docker-compose environment
  • My feature branch builds on Github

@BalintBende BalintBende self-assigned this Jun 12, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

1 similar comment

This comment has been minimized.

@eriadam eriadam merged commit 9b4da4d into develop Jun 13, 2024
1 of 3 checks passed
@eriadam eriadam deleted the feature/BMSPT-275-bcfzip-with-stream branch June 13, 2024 15:57
Copy link

Unit Test Results

0 files  ±0  0 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 9b4da4d. ± Comparison against base commit d911a85.

BalintBende added a commit that referenced this pull request Jun 25, 2024
* [BMSPT-275] implementation of bcf zip creation with memory stream

* [BMSPT-275] refactor & reorganization

* [BMSPT-275] added unit tests

* Simplified IConverter API. Added support for predefined output streams.

* [BMSPT-297] Checking incoming streams if they can be used for the given use case. Added documentation.

---------

Co-authored-by: DanielLepold <[email protected]>
Co-authored-by: Adam Eri <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants