Update start/end input text to reflect geocoding #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Purpose: Mitigate bad geocoding like in issue #230 where typing an address like "250 Howard Street" results in a generic result for just "Howard Street." How it works today: If you click on a geocoded result from the dropdown, the input text gets replaced with a description of that geocoded result. But if you type something and hit Return, your typed text stays unchanged, giving no indication of what result was found. What this commit changes: Typing something and hitting Return also causes your input text to be replaced by a description of the geocoded result. Future work: Fix Photon not to return results at all if they fail to match part of what you typed (or flag such results as inexact). Get better address data into our geocoder.
abhumbla
approved these changes
Aug 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose: Mitigate bad geocoding like in issue #230 where typing an address like "250 Howard Street" results in a generic result for just "Howard Street."
How it works today: If you click on a geocoded result from the dropdown, the input text gets replaced with a description of that geocoded result. But if you type something and hit Return, your typed text stays unchanged, giving no indication of what result was found.
What this commit changes: Typing something and hitting Return will also replace your input text with a description of the geocoded result.
Future work: Fix Photon not to return results at all if they fail to match part of what you typed (or flag such results as inexact). Get better address data into our geocoder.