Upgrade dependencies #325
Merged
Upgrade dependencies #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
these are used indirectly by vite and autoprefixer. there is no need for us to require our own copy of them
note: this changes how SVGs are imported
this fixes the problem with dots in paths, so can remove our workaround
|
@Andykmcc since you're thinking about JS dependencies, have a look? |
and move eslint to devDependencies
fixes CJS deprecation warning in Vite 5
Andykmcc
approved these changes
Apr 22, 2024
| "last 1 safari version" | ||
| ] | ||
| }, | ||
| "jest": { |
There was a problem hiding this comment.
are you getting rid of this because we dont use it?
There was a problem hiding this comment.
Yeah, I'm removing all the dependencies we don't use. If you want to write frontend unit tests and think we should use Jest, feel free to add it back.
graue
added a commit
that referenced
this pull request
Jul 25, 2024
Upgrades everything to the latest except for immer, maplibre-gl, react-redux, redux, and redux-thunk for the reasons noted in PR #325; @headlessui/react because something in 2.x broke BikeHopper and it wasn't immediately obvious what to change; eslint out of laziness (eslint-plugin-react now supports eslint 9.x, but not sure if we'll have to make more changes).
Merged
graue
added a commit
that referenced
this pull request
Jul 25, 2024
Upgrades everything to the latest except for immer, maplibre-gl, react-redux, redux, and redux-thunk for the reasons noted in PR #325; @headlessui/react because something in 2.x broke BikeHopper and it wasn't immediately obvious what to change; eslint out of laziness (eslint-plugin-react now supports eslint 9.x, but not sure if we'll have to make more changes).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades all our npm dependencies except for:
and some packages we weren't actually using that I removed.
For the redux packages and immer, I figure we can wait a bit until those browsers being dropped are less used. The features they've adopted are unavailable for 3-5% of web users, which seems high when the old version works fine.
Note that the new
vite-plugin-svgrrequires changes to how we import SVG files.