Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix map controls getting stuck when top bar hides #300

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Conversation

graue
Copy link
Contributor

@graue graue commented Jan 25, 2024

I forgot to account for the map top controls in #297, causing this:

image

This is kind of a hacky fix. A prop is passed in which isn't actually used, but it forces a re-render, so the useLayoutEffect in MapPlusOverlay recomputes the position of the map top controls.

@graue graue merged commit a34a8e1 into main Jan 25, 2024
3 checks passed
@graue graue deleted the graue/transition-fix branch January 25, 2024 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant