Support public Nominatim for demos; LA and Chicago region defs #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also update Chicago values for rebase
behind a flag, for demo/dev ONLY this is useful for testing in a new region without spinning up photon for that region needs work, it currently is not limited to the supported region because adding bounded=1 is making results *in* that region disappear. it is not finding some Chicago locations I'm trying -- at all, not just not as the first result -- unless I explicitly add ", Chicago"
Andykmcc
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used this branch locally to help me get around Chicago and Los Angeles while visiting them. I'd like to figure out how we can merge it.
One of the features is a hack to use the public Nominatim API for geocoding, to avoid the difficulty and heavy resource usage of standing up local Photon. This is only suitable for local development and local demos, as the usage policy limits requests to an absolute maximum of 1 per second across all users. To be a respectful user of the API, this branch throttles lookups to one per 3 seconds and disables autocomplete. I also find I have to include the city name e.g. "Lincoln Park Zoo, Chicago" or "Echoplex, Los Angeles" to get usable results.
I'm aware this PR is somewhat at odds with #293 but I think it's useful to be able to do it this way too, less to set up. Or we could potentially iterate after merging this and remove the geoconfiguration part once we have a clean way to use Docker to run all the relevant services, while keeping the public Nominatim capability.