feat: trigger oobErrorNoTarget for missing oob swap targets #2985
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the parent of an
oob-swap
will not get anoobErrorNoTarget
event when added to thehxOn
event trigger.Given the following code:
And the following message from the server
Nothing will happen. But with this change the
console.log
will run.Corresponding issue:
Testing
This was tested manually using a very similar code to the above. I was trying to figure out where a test would fit in
hx-swap-oob.js
but it wasn't immediately obvious to me. If you think the change is correct I will spend more time on figuring out a test for it.Checklist
master
for website changes,dev
forsource changes)
approved via an issue
npm run test
) and verified that it succeeded