[Documentartion]Add more information about other swap strategies #2889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexpetros @Telroshan I would love to get your feedback on this documentation update. |
3 tasks
|
@MichaelWest22 Can you have a look here? |
|
Yeah I think you have done a good job here describing most of the issues. Maybe the alternative swap strategies section could go above the troublesome tables as I think it is more useful to learn first before the exception for wrapping tables in templates and the SVG exception. |
Telroshan
reviewed
Sep 18, 2024
|
|
||
| As mentioned previously when using swap strategies other than `true` or `outerHTML` the encapsulating tags are stripped, as such you need to excapsulate the returned data with the correct tags for the context. | ||
|
|
||
| For a table that uses `<tbody>`: |
There was a problem hiding this comment.
Maybe to make it extra clear, precise here that the goal is to swap a <tr> tag in eventually? (just like you explicitly mention <li> and <p> below!)
There was a problem hiding this comment.
I have update the language lmk what you think!
Telroshan
approved these changes
Sep 18, 2024
|
That was fast, thanks 😁 |
This was referenced Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This extends the
hx-swap-oobdocumentation with more information on using it with alternate swap strategies which can be finicky, all my conclusions are based on trial and error using htmx 2.0.2 on Firefox 129.More background on all the testing I did can be found in #2560
Checklist
masterfor website changes,devforsource changes)
approved via an issue
[ ] I ran the test suite locally (npm run test) and verified that it succeeded