Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove implicit brace wrapping for hx-vals #2888

Closed
wants to merge 2 commits into from
Closed

Remove implicit brace wrapping for hx-vals #2888

wants to merge 2 commits into from

Conversation

shouya
Copy link
Contributor

@shouya shouya commented Sep 9, 2024 •
edited
Loading

Description

I removed the implicit wrapping of braces around hx-vals values.

Corresponding issue: #2885

Testing

Existing tests are adapted and a new test is added.

Checklist

  • I have read the contribution guidelines
  • I have targeted this PR against the correct branch (master for website changes, dev for
    source changes)
  • This is either a bugfix, a documentation update, or a new feature that has been explicitly
    approved via an issue
  • I ran the test suite locally (npm run test) and verified that it succeeded

Sorry for opening a duplicated PR. #2887 closed itself when I force push on my branch.

@shouya shouya changed the title Unexpected brace wrapping for hx-vals Remove implicit brace wrapping for hx-vals Sep 9, 2024
@shouya shouya marked this pull request as ready for review September 9, 2024 14:16
@Telroshan Telroshan added under discussion Issues that are being considered but require further alignment needs rebase/retarget labels Sep 10, 2024
@shouya
Copy link
Contributor Author

shouya commented Sep 11, 2024

See discussion in #2885.

@shouya shouya closed this Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs rebase/retarget under discussion Issues that are being considered but require further alignment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shouya @Telroshan