fix restoreHistory title replacment #2841
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It seems that when the handleTitle() function was introduced the restoreHistory() title setting code was accidently changed to use fragment.title instead of the proper cached.title. Firefox does not keep track of title during history switching so title doesn't change now because there is no title inside the fragment data. Chrome works fine as it tracks the page title itself.
Corresponding issue:
#2833
Testing
I've tested this trival change in firefox and chrome to make sure it works fine and updates the title as expected
Checklist
master
for website changes,dev
forsource changes)
approved via an issue
npm run test
) and verified that it succeeded