Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ensure Github actions run tests in Python 3.10 and 3.11 #42

Merged
merged 4 commits into from
Feb 13, 2024

Conversation

unmonoqueteclea
Copy link
Contributor

We didn't update the Python versions where we want tests to run. They were just running in Python 3.9. I also removed the Install Test Dependencies section, because those two dependencies are already part of the package requirements list.

I am not sure if this PR will trigger the new workflow with the new versions, or we will have to merge it first and it will run in the next PR. Anyways, I found that wheels build process failed in the previous PR. We will need to check why (I still don't know), because wheels make that Python packages installations much faster and stable.

Furthermore, I am seeing a strange error locally in a test. I want to check tests logs here before starting to work on it.

cc @mmerce @jaor

@unmonoqueteclea unmonoqueteclea force-pushed the master branch 7 times, most recently from 779bb06 to e55b14b Compare February 5, 2024 13:45
@unmonoqueteclea
Copy link
Contributor Author

Sorry for the noise, I finished testing Github Actions.

Tests are finally running in 3 different Python versions (3.9, 3.10 and 3.11) and the pipeline that builds the wheels for macOS is working correctly.

The pipeline that builds wheels for Linux is not working and the reason was explained some time ago here: The problem is that we are extending Tensorflow with C extensions to add a new small feature to it, tree embeddings. This is making Sensenet much more complex to build and to install.

In Charlie's words:

 This extension has been such a pain so many times that maybe we should remove it.

Maybe, we should re-consider this

@unmonoqueteclea
Copy link
Contributor Author

Hey, any comments? Shall I merge this?

@unmonoqueteclea
Copy link
Contributor Author

Tests are passing, and changes are just related with tests and Github Actions, I will merge this.

@unmonoqueteclea unmonoqueteclea merged commit cce25d0 into bigmlcom:master Feb 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants