-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor display options #219
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ds serialization of BdvSupplier. Sets a default BdvSupplier
…ven inside a class ?)
…nverters, refactor location of adapters
…ound and adds some scijava helper commands
…ommand to bdv menus and card panels
… opening AbstractSpimData objects
Ok @tischi , let's go for it! |
Hmm I'll fix #180 before |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tischi,
Here's the big refactoring. It removes a lot of stuff with bdv playground, but together with https://github.com/NicoKiaru/bigdataviewer-spimdata-extras and https://github.com/NicoKiaru/bigdataviewer_playground_display we get a better separation of tasks, the same functionalities as before, and an easier and more flexible to extend them.
This will require a bit of time to adapt your code, but it'll be worth.
We should be able to solve, or provide an easier way to fix:
The two things which are allowing this is the serialization of the suppliers of Bdv, which allows to store preferences conveniently for how the bdv is build. I also added plugins which can basically handle any sourceandconverter operation based on a tag of xml of spimdata objects, when spimdata objects are loaded or saved ( think displaysettings, projection, and also custom converters for label images)
Maybe we should tackle #180 while we're at it.