Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor display options #219

Merged
merged 26 commits into from
May 7, 2021
Merged

Refactor display options #219

merged 26 commits into from
May 7, 2021

Conversation

NicoKiaru
Copy link
Collaborator

@tischi,

Here's the big refactoring. It removes a lot of stuff with bdv playground, but together with https://github.com/NicoKiaru/bigdataviewer-spimdata-extras and https://github.com/NicoKiaru/bigdataviewer_playground_display we get a better separation of tasks, the same functionalities as before, and an easier and more flexible to extend them.

This will require a bit of time to adapt your code, but it'll be worth.

We should be able to solve, or provide an easier way to fix:

The two things which are allowing this is the serialization of the suppliers of Bdv, which allows to store preferences conveniently for how the bdv is build. I also added plugins which can basically handle any sourceandconverter operation based on a tag of xml of spimdata objects, when spimdata objects are loaded or saved ( think displaysettings, projection, and also custom converters for label images)

Maybe we should tackle #180 while we're at it.

…ds serialization of BdvSupplier. Sets a default BdvSupplier
@NicoKiaru
Copy link
Collaborator Author

Ok @tischi , let's go for it!

@NicoKiaru
Copy link
Collaborator Author

Hmm I'll fix #180 before

@NicoKiaru NicoKiaru merged commit 359a143 into master May 7, 2021
@NicoKiaru NicoKiaru deleted the refactor_display_options branch May 7, 2021 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant