Update frontend-deploy.yml

big213 · Nov 25, 2023 · e29bd55 · e29bd55
1 parent 1433e23
commit e29bd55
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 8 deletions.
diff --git a/.github/workflows/frontend-deploy.yml b/.github/workflows/frontend-deploy.yml
@@ -39,10 +39,7 @@ jobs:
           SOCIAL_LOGIN_ENABLED:
           TEMP_STORAGE_PATH: temp
           STRIPE_PUB_KEY:
-      - name: Deploy to Firebase
-        uses: w9jds/firebase-action@master
-        with:
-          args: deploy --only hosting
-        env:
-          FIREBASE_TOKEN: ${{ secrets.FIREBASE_TOKEN }}
-          PROJECT_PATH: ./frontend
+      - name: Create SA key
+        run: echo '${{ secrets.FIREBASE_SERVICE_ACCOUNT }}' > $HOME/gcloud.json
+      - name: Deploy Hosting
+        run: export GOOGLE_APPLICATION_CREDENTIALS=$HOME/gcloud.json && cd frontend && npx firebase-tools deploy --only hosting --json
diff --git a/backend/functions/src/config/index.ts b/backend/functions/src/config/index.ts
@@ -1,4 +1,4 @@
-import { defineInt, defineString, projectID } from "firebase-functions/params";
+import { defineInt, defineString } from "firebase-functions/params";
 
 // in dev mode, SQL errors are not masked, and SQL queries/errors are logged
 export const isDev = !!(process.env.FUNCTIONS_EMULATOR ?? process.env.DEV);