Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Update PET metadata dependencies #1906

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Conversation

effigies
Copy link
Collaborator

@effigies effigies commented Mar 3, 2024

Fixes #1897.

@effigies
Copy link
Collaborator Author

effigies commented Mar 3, 2024

Well, this didn't work. For some reason it's causing failures in non-PET examples. @rwblair I modeled this off of the coordsystem_nirs.json, but it seems that I'm missing something about how the validator works.

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.57%. Comparing base (7773eda) to head (1008250).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1906   +/-   ##
=======================================
  Coverage   83.57%   83.57%           
=======================================
  Files          92       92           
  Lines        3890     3890           
  Branches     1271     1271           
=======================================
  Hits         3251     3251           
  Misses        541      541           
  Partials       98       98           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies effigies force-pushed the fix/pet-dependencies branch from 1008250 to 08167de Compare March 7, 2024 21:05
@effigies effigies merged commit 70dcc1a into master Mar 7, 2024
21 of 28 checks passed
@effigies effigies deleted the fix/pet-dependencies branch March 7, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PET recon parameter error - need to implement a conditional statement
1 participant