-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add field for timezone #1968
Comments
@JojoVh |
So this would be a recommended field for the description acq_time in scans.json or sessions.json files? |
What is the use case for specifying time zone? The two use cases we considered are wanting absolute time coordinates and wanting to preserve time of day information. For the latter, the time zone is not generally relevant. If we do add timezones, I would probably prefer just to use full RFC3339. |
Thank you very much for your enthusiasm and feedback. I would recommend the field in the scans.json the most, because the timepoint of scanning matters most, but it makes sense to also recommend it in the sessions.json The use-case for this is the following: However, toolboxes such as mne and mne_bids make a distinction between local time and UTC. If UTC is not specified with the trailing Z, the time is read in the time zone of the computer. We found out that in the context of data sharing and international collaboration, it caused significant issues with shifts in artifact annotations and in shift in chronic data (e.g. to determine day/night differences). Shifting the entire dataset to UTC is not an option for us, but a standard field for the local time does not exist yet. (As a maintainer, my colleague aims to have such a field read in by mne_bids when specified) What is your opinion? Would such a field be possible to take up in the BIDS standard? Best wishes ICN, Department of Neurology, |
Ah, thank you for making that clearer. Yes, if you need time-of-day and between-TZ timedeltas, then that's going to matter. It looks like we specify in text that only IMO we should simply fully adopt RFC3339, which uses
This does not use time zone codes but whole-minute UTC +/- offsets. Would this satisfy, or is the use of named timezone codes in JSON particularly important? |
Dear @effigies I am happy to read, that you permit already to read the alphabetic timezone codes with your regex. Yes, I think that the documentation of the used timezone code is important. If the BIDS specification however determines homogeneously where to document the timezone with standard abbreviations (https://www.utctime.net/time-zone-abbreviations) in scans or sessions.json, What is your opinion? |
Hi @JojoVh, just getting back to this (thanks to bids-standard/bids-validator#131 for reminding me). RFC3339 being a standard and a subset of ISO8601 makes it extremely well supported, so I'm hesitant to support adding a BIDS-specific extension. If we did that, I would want it also to be an ISO8601 subset to ensure that people don't have to consult BIDS to parse their datetimes. |
Your idea
Dear BIDS developers
I would like to raise the issue that there is a need for timezone specification.
If the time indicator 'Z' for UTC time is lacking, the time zone is assumed to be local time. But this is not necessarily true when working internationally, and causes time zoning issues.
I would like to suggest adding this in the corresponding json file with the field "timezone", which SHOULD be specified.
{
"acq_time":{
"Description":"date and time of the scan acquisition in the format YYYY-MM-DDThh:mm:ss",
"Units":"seconds"
"Timezone":"CET"
}
}
as specified in this list: https://www.utctime.net/time-zone-abbreviations
Would that be possible to implement?
I am referring to an adaptation of the current section:
https://bids-specification.readthedocs.io/en/stable/common-principles.html#units
Describing dates and timestamps:
Date time information MUST be expressed in the following format YYYY-MM-DDThh:mm:ss[.000000][Z] (year, month, day, hour (24h), minute, second, optional fractional seconds, and optional UTC time indicator). This is almost equivalent to the RFC3339 "date-time" format, with the exception that UTC indicator Z is optional and non-zero UTC offsets are not indicated. If Z is not indicated, time zone is always assumed to be the local time of the dataset viewer. No specific precision is required for fractional seconds, but the precision SHOULD be consistent across the dataset. For example 2009-06-15T13:45:30.
The text was updated successfully, but these errors were encountered: