Added instructions to run the project. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
or npm install --save three |
Mizux
reviewed
Nov 24, 2023
| ------------- | ||
|
|
||
| `sudo npm install http-server -g` |
There was a problem hiding this comment.
why using sudo ? You can install "globally" for the user
ref:
Mizux
reviewed
Nov 24, 2023
|
|
||
| #### 1) Install http-server globaly: | ||
| ------------- |
There was a problem hiding this comment.
- why adding a breakline after this H4 (4 #) ?
- Why use H4 when above you have a H2 (2 #) ?
piyushbaibhav
approved these changes
Nov 24, 2023
narayan954
reviewed
Nov 24, 2023
| @@ -6,3 +6,6 @@ npm-debug.log | |||
| *.png | |||
| .env | |||
| .DS_Store | |||
| package-lock.json | |||
| .gitignore | |||
| @@ -6,3 +6,6 @@ npm-debug.log | |||
| *.png | |||
| .env | |||
| .DS_Store | |||
| package-lock.json | |||
| .gitignore | |||
| package.json | |||
There was a problem hiding this comment.
also, package.json and it's lock are good to be present, not gitignored
ayush-india
reviewed
Nov 27, 2023
| ------------- | ||
|
|
||
| `sudo npm install http-server -g` |
There was a problem hiding this comment.
why not just use python
python -m http.server 6969
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Included instructions on how to the the project (Credit to @nigelreign). Also added package-lock.json & package.json to .gitignore