Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc doc changes #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

kianmeng
Copy link

Besides other documentation changes, this commit ensures the generated
HTML doc for HexDocs.pm will become the source of truth for this Elixir
library and leverage on latest features of ExDoc.

@kianmeng
Copy link
Author

@bglusman Should I resolve the conflict and resubmit the PR again?

@bglusman
Copy link
Owner

@kianmeng oh thank you! I hadn't seen this when I bumped versions a few weeks ago, much appreciated!

@bglusman
Copy link
Owner

Hmm also hand't noticed its now failing lots of tests on CI! 😢 Feel free to take a crack at fixing those also or I'll try and get to soon if you don't

Besides other documentation changes, this commit includes all relevant
documents to the generated HTML doc for HexDocs.pm and leverages on
latest features of ExDoc.
@kianmeng
Copy link
Author

kianmeng commented Feb 2, 2022

@bglusman Done. Please check.

Also added another PR for GitHub Actions, #6.

@bglusman
Copy link
Owner

Hmm, sorry I didn't look at this in 2 years 🙃 in my copious free time I'll try and figure out whats going on, but, also, apologies I'll try and be more responsive next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants