New Analyzer: accteststep: returns resource.TestStep literals for lat…

…er passes

CHANGELOG.md

@@ -11,6 +11,7 @@ NOTES
 
 FEATURES
 
+* **New Analyzer:** `accteststep`: returns `resource.TestStep` literals for later passes
 * **New Check:** `AT005`: check for acceptance test names missing `TestAcc` prefix
 * **New Check:** `AT006`: check for acceptance tests containing multiple `resource.Test()` invocations
 * **New Check:** `AT007`: check for acceptance tests containing multiple `resource.ParallelTest()` invocations

helper/terraformtype/helper_resource_teststep.go

@@ -55,3 +55,13 @@ func NewHelperResourceTestStepInfo(cl *ast.CompositeLit, info *types.Info) *Help
 func (info *HelperResourceTestStepInfo) DeclaresField(fieldName string) bool {
 	return info.Fields[fieldName] != nil
 }
+
+// IsHelperResourceTypeTestStep returns if the type is TestStep from the helper/schema package
+func IsHelperResourceTypeTestStep(t types.Type) bool {
+	switch t := t.(type) {
+	case *types.Named:
+		return IsHelperResourceNamedType(t, TypeNameTestStep)
+	default:
+		return false
+	}
+}

passes/accteststep/accteststep.go

@@ -0,0 +1,50 @@
+package accteststep
+
+import (
+	"go/ast"
+	"reflect"
+
+	"github.com/bflad/tfproviderlint/helper/terraformtype"
+	"golang.org/x/tools/go/analysis"
+	"golang.org/x/tools/go/analysis/passes/inspect"
+	"golang.org/x/tools/go/ast/inspector"
+)
+
+var Analyzer = &analysis.Analyzer{
+	Name: "accteststep",
+	Doc:  "find github.com/hashicorp/terraform-plugin-sdk/helper/resource.TestStep literals for later passes",
+	Requires: []*analysis.Analyzer{
+		inspect.Analyzer,
+	},
+	Run:        run,
+	ResultType: reflect.TypeOf([]*terraformtype.HelperResourceTestStepInfo{}),
+}
+
+func run(pass *analysis.Pass) (interface{}, error) {
+	inspect := pass.ResultOf[inspect.Analyzer].(*inspector.Inspector)
+	nodeFilter := []ast.Node{
+		(*ast.CompositeLit)(nil),
+	}
+	var result []*terraformtype.HelperResourceTestStepInfo
+
+	inspect.Preorder(nodeFilter, func(n ast.Node) {
+		x := n.(*ast.CompositeLit)
+
+		if !isResourceTestStep(pass, x) {
+			return
+		}
+
+		result = append(result, terraformtype.NewHelperResourceTestStepInfo(x, pass.TypesInfo))
+	})
+
+	return result, nil
+}
+
+func isResourceTestStep(pass *analysis.Pass, cl *ast.CompositeLit) bool {
+	switch v := cl.Type.(type) {
+	default:
+		return false
+	case *ast.SelectorExpr:
+		return terraformtype.IsHelperResourceTypeTestStep(pass.TypesInfo.TypeOf(v))
+	}
+}