Skip to content

Commit

Permalink
New Extra Check: XAT001: check for TestCase missing ErrorCheck (#227)
Browse files Browse the repository at this point in the history
* deps: Bump github.com/hashicorp/terraform-plugin-sdk/[email protected]

Updated via:

```
go get github.com/hashicorp/terraform-plugin-sdk/[email protected]
go mod tidy
go mod vendor
```

* deps: Bump github.com/hashicorp/terraform-plugin-sdk@v1-maint

To prevent `go-getter` errors.

Updated via:

```
go get github.com/hashicorp/terraform-plugin-sdk@v1-maint
go mod tidy
go mod vendor
```

* New Extra Check: XAT001: check for TestCase missing ErrorCheck

Reference: #226
  • Loading branch information
bflad authored Mar 18, 2021
1 parent 1743c0f commit ae9ed13
Show file tree
Hide file tree
Showing 826 changed files with 89,147 additions and 24,331 deletions.
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
# v0.23.0

FEATURES

* **New Extra Check:** `XAT001`: check for `TestCase` missing `ErrorCheck` implementation

# v0.22.0

FEATURES
Expand Down
6 changes: 6 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,12 @@ Standard lint checks are enabled by default in the `tfproviderlint` tool. Opt-in

Extra lint checks are not included in the `tfproviderlint` tool and must be accessed via the `tfproviderlintx` tool or [added to a custom lint tool](#implementing-a-custom-lint-tool). Generally these represent advanced Terraform Plugin SDK functionality that is not appropriate for all Terraform Providers.

### Extra Acceptance Test Checks

| Check | Description | Type |
|---|---|---|
| [XAT001](xpasses/XAT001) | check for `TestCase` missing `ErrorCheck` | AST |

### Extra Resource Checks

| Check | Description | Type |
Expand Down
6 changes: 3 additions & 3 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ go 1.16

require (
github.com/bflad/gopaniccheck v0.1.0
github.com/hashicorp/terraform-plugin-sdk v1.9.0
github.com/hashicorp/terraform-plugin-sdk/v2 v2.0.0
golang.org/x/tools v0.0.0-20200713011307-fd294ab11aed
github.com/hashicorp/terraform-plugin-sdk v1.16.1-0.20210222152151-32f0219df5b5
github.com/hashicorp/terraform-plugin-sdk/v2 v2.4.4
golang.org/x/tools v0.0.0-20201028111035-eafbe7b904eb
)
209 changes: 152 additions & 57 deletions go.sum

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions helper/terraformtype/helper/resource/type_testcase.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import (

const (
TestCaseFieldCheckDestroy = `CheckDestroy`
TestCaseFieldErrorCheck = `ErrorCheck`
TestCaseFieldIDRefreshName = `IDRefreshName`
TestCaseFieldIDRefreshIgnore = `IDRefreshIgnore`
TestCaseFieldIsUnitTest = `IsUnitTest`
Expand Down
78 changes: 77 additions & 1 deletion vendor/cloud.google.com/go/CHANGES.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 9 additions & 5 deletions vendor/cloud.google.com/go/CONTRIBUTING.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions vendor/cloud.google.com/go/compute/metadata/metadata.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 8 additions & 8 deletions vendor/cloud.google.com/go/go.mod

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

30 changes: 25 additions & 5 deletions vendor/cloud.google.com/go/go.sum

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit ae9ed13

Please sign in to comment.