Dep updates; StalledDiscussionFlow progress #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We'll need this to be able to use the ConfigFileProvider in the StalledDiscussionFlow, since the @configfile annotation only seems to work well for injection into event-listener methods. The `org.jetbrains:annotations` dependency doesn't get pulled in implicitly any longer, so I've just switched usage of the @NotNull && @nullable annotations from there to the SmallRye equivalents, which are available. Something that I'm not 100% sure about is the test changes here: I guess the Jackson/SnakeYAML handling of null fields changed somewhere along the way.
Without these, the affected fields were always being set to a null or default value for the type. For example, botUserLogin would always be null, and stalledDiscussionPollTimeMins would always be 0.
grdryn
changed the title
- Token expires every hour, so a new token needs to be fetched every time, rather than just being able to get one at object initialization. - The "stalledDiscussionPollTimeMins" property set in the bf2-arch-bot.yml seemingly can't be used in the @scheduled annotation, since it's not available early enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.