Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade typos job in CI and fix the typos detected #16610

Closed
alice-i-cecile opened this issue Dec 2, 2024 · 2 comments · Fixed by #16712
Closed

Upgrade typos job in CI and fix the typos detected #16610

alice-i-cecile opened this issue Dec 2, 2024 · 2 comments · Fixed by #16712
Labels
A-Build-System Related to build systems or continuous integration A-Cross-Cutting Impacts the entire engine D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! X-Contentious There are nontrivial implications that should be thought through

Comments

@alice-i-cecile
Copy link
Member

The new typos version catches a bunch of new typos. We should fix them, and then update.

Originally posted by @alice-i-cecile in #16602 (comment)
@alice-i-cecile alice-i-cecile added D-Trivial Nice and easy! A great choice to get started with Bevy A-Build-System Related to build systems or continuous integration S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! A-Cross-Cutting Impacts the entire engine X-Uncontroversial This work is generally agreed upon labels Dec 2, 2024
@rparrett
Copy link
Contributor

rparrett commented Dec 2, 2024

We may want to cross-reference #16273 where parametrize and metallicity were recently discussed.

#16273 (comment) (rendering folks may want to weigh in)
#16273 (review) (other math folks may want to weigh in)

@alice-i-cecile alice-i-cecile added X-Contentious There are nontrivial implications that should be thought through and removed X-Uncontroversial This work is generally agreed upon labels Dec 2, 2024
@BenjaminBrienen
Copy link
Contributor

BenjaminBrienen commented Dec 3, 2024 •
edited
Loading

My apologies for those suggestions to typos-ci which became false positives.

@homersimpsons homersimpsons mentioned this issue Dec 8, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Dec 8, 2024
@homersimpsons
⬆️ Upgrade typos and its configuration (#16712)
a6b5f80 
# Objective

Fixes #16610, related to #16702

## Solution

Upgrade typos and its configuration

## Testing

- Did you test these changes? If so, how? No
- Are there any parts that need more testing? No
- How can other people (reviewers) test your changes? Is there anything
specific they need to know? No
- If relevant, what platforms did you test these changes on, and are
there any important ones you can't test? Not applicable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Build-System Related to build systems or continuous integration A-Cross-Cutting Impacts the entire engine D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! X-Contentious There are nontrivial implications that should be thought through
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

⬆️ Upgrade typos and its configuration homersimpsons/bevy
3 participants
@rparrett @alice-i-cecile @BenjaminBrienen