Conditional extraction to render world can cause desync #15871
Labels
A-Rendering
Drawing game state to the screen
C-Bug
An unexpected or incorrect behavior
P-Regression
Functionality that used to work but no longer does. Add a test for this!
S-Needs-Design
This issue requires design work to think about how it would best be accomplished
Milestone
In retained render world, despawning the main world entity or removing its components (#15582) are the only way to remove already inserted components from render world.
Some extraction systems seem to rely on the previous behavior by extracting components conditionally, expecting render entities to be wiped out every frame.
Bloom
Skip bloom rendering if HDR is disabled #15856
bevy/crates/bevy_core_pipeline/src/bloom/settings.rs
Lines 222 to 229 in 813c759
Turning HDR off causes crash because
Bloom
component is not removed.ChromaticAberration
bevy/crates/bevy_core_pipeline/src/post_process/mod.rs
Line 499 in 813c759
Setting
intensity = 0
will not be synchronized to render world if you have non-zero value currently, for example.ContrastAdaptiveSharpening
bevy/crates/bevy_core_pipeline/src/contrast_adaptive_sharpening/mod.rs
Line 88 in 813c759
extract_depth_of_field_settings
bevy/crates/bevy_core_pipeline/src/dof/mod.rs
Line 825 in 813c759
extract_taa_settings
bevy/crates/bevy_core_pipeline/src/taa/mod.rs
Line 376 in 813c759
extract_camera_prepass_phasebevy/crates/bevy_core_pipeline/src/core_3d/mod.rs
Line 589 in 813c759
extract_clusters
bevy/crates/bevy_pbr/src/cluster/mod.rs
Line 533 in 813c759
extract_camera_previous_view_data
bevy/crates/bevy_pbr/src/prepass/mod.rs
Line 587 in 813c759
extract_lights
bevy/crates/bevy_pbr/src/render/light.rs
Line 381 in 813c759
extract_ssao_settings
bevy/crates/bevy_pbr/src/ssao/mod.rs
Line 538 in 813c759
extract_volumetric_fog
bevy/crates/bevy_pbr/src/volumetric_fog/render.rs
Line 278 in 813c759
extract_visible_components
bevy/crates/bevy_render/src/extract_component.rs
Line 222 in 813c759
extract_cameras
bevy/crates/bevy_render/src/camera/camera.rs
Line 1056 in 813c759
bevy/crates/bevy_render/src/camera/camera.rs
Lines 1073 to 1075 in 813c759
extract_default_ui_camera_view
bevy/crates/bevy_ui/src/render/mod.rs
Line 521 in 813c759
Most of them looks like optimization. Unfortunate but won't cause visual desync probably.
The text was updated successfully, but these errors were encountered: