Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.14 migration: Slightly more help for users who had their colors changed #1392

Merged
merged 3 commits into from
Jun 12, 2024

Conversation

rparrett
Copy link
Contributor

@rparrett rparrett commented Jun 12, 2024

These are simple changes to migrate, but we are asking users to do a lot of research and could be helping them out a bit more.

I think these three colors were the extent of the damage for "color values getting changed," though maybe we could also throw "colors that simply had their names changed" into the table as well.

Do we have a handy list of those? I thought they were listed in some iteration of the migration guide previously.

For reference:

bevyengine/bevy#12451
bevyengine/bevy#12333
bevyengine/bevy#12328

@rparrett rparrett requested a review from BD103 June 12, 2024 13:23
@rparrett rparrett added C-Feature A new feature, making something new possible A-Migration Guides labels Jun 12, 2024
@alice-i-cecile alice-i-cecile requested a review from viridia June 12, 2024 13:28
@alice-i-cecile alice-i-cecile added this to the Release v0.14 milestone Jun 12, 2024
@rparrett rparrett changed the title 0.14 Migration: Slightly more help for users who had their colors changed 0.14 migration: Slightly more help for users who had their colors changed Jun 12, 2024
Copy link
Member

@BD103 BD103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like this change, thank you! I have one nit about capitalizing CSS, but the rest is good!

@BD103 BD103 added the S-Ready-For-Final-Review Ready for a maintainer to consider for merging label Jun 12, 2024
Co-authored-by: BD103 <[email protected]>
@alice-i-cecile alice-i-cecile enabled auto-merge June 12, 2024 15:20
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jun 12, 2024
Merged via the queue into bevyengine:main with commit 8070a66 Jun 12, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Migration Guides C-Feature A new feature, making something new possible S-Ready-For-Final-Review Ready for a maintainer to consider for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants