Most of my changes #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also afects which sources are built
Now my editor is less confused and I can see where the engine is tied to the game... Also no perf changes
It's almost all pico/picosystem-specific or debug code
Oh, that's why the picosystem include was there
Now engine/ doesn't depend on the picosystem SDK
The only user of chunk_traversable in engine/
Depends on a bunch of game state
only 20us higher avg frame time in benchmark so...
Causes build issues when time.h declares daylight ... and duplicate symbol errors with emscripten
Thanks(?) clang
Avoid divide by 0 in rasterise
More divide by 0
|
Awesome, thanks! Will integrate it on the weekend and fix any broken bits if needed 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be everything except the 32blit SDK port (that's still a bit wonky). Mostly a big pile of moving things around so that files can be built separately.
I think I tested this for performance changes. It's possible some of the debug options are broken due to missing declarations, only really tested
BENCHMARKandGAMESCOM(as that's the biggest one).