Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This isn't a real PR. I made it to demonstrate how PR review works in GitHub. #36

Merged
merged 3 commits into from
Mar 11, 2021
Merged

This isn't a real PR. I made it to demonstrate how PR review works in GitHub. #36

merged 3 commits into from
Mar 11, 2021

Conversation

nlharris
Copy link
Member

Fixes #123

@nlharris
Changes to schema
8ff15c8 
Fixes #123
@nlharris nlharris changed the title Changes to schema This isn't a real PR. I made it to demonstrate how PR review works in GitHub. Jan 21, 2021
@nlharris nlharris linked an issue Feb 12, 2021 that may be closed by this pull request
various minor edits and fixes #24
Open
9 tasks
@nlharris nlharris linked an issue Mar 11, 2021 that may be closed by this pull request
Add best_practice to menu and home page #39
Closed
@nlharris nlharris marked this pull request as ready for review March 11, 2021 16:57
@nlharris nlharris removed a link to an issue Mar 11, 2021
various minor edits and fixes #24
Open
9 tasks
@nlharris
Copy link
Member Author

I hand-linked issue #39 to this fake PR. If I now merge this PR, will it cause #39 to no longer be open? (I am avoiding using any of the special words)

@nlharris nlharris merged commit c3485b9 into master Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add best_practice to menu and home page
1 participant
@nlharris