Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support reading MQTT host and Rest Host from Env #46

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Support reading MQTT host and Rest Host from Env #46

wants to merge 2 commits into from

Conversation

enyachoke
Copy link

I noticed that depending on the region, the API and MQTT endpoints may vary. My device for example connects to mqtt-s.ecoflow.com and api-s.ecoflow.com

@berezhinskiy
Copy link
Owner

@enyachoke In my opinion, it would be more advantageous to specify ECOFLOW_MQTT_HOST and ECOFLOW_REST_HOST within the same location as the other environment variables in the main() function, and subsequently pass them to the EcoflowAuthentication class. This approach will contribute to maintaining simplicity and readability in the code. Thanks

@berezhinskiy berezhinskiy self-requested a review December 8, 2023 09:48
@berezhinskiy
Copy link
Owner

@enyachoke Additionally, kindly revise the README.md to incorporate the new environment variable into the Usage section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berezhinskiy berezhinskiy Awaiting requested review from berezhinskiy

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@enyachoke @berezhinskiy