Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refact!: define a "scopeable model" base class + modelviewset scoping #536

Draft
wants to merge 27 commits into
base: develop
Choose a base branch
from
Draft

refact!: define a "scopeable model" base class + modelviewset scoping #536

wants to merge 27 commits into from

Conversation

davidlougheed
Copy link
Member

No description provided.

@codecov Codecov
Copy link

codecov bot commented Sep 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 94.49275% with 19 lines in your changes missing coverage. Please review.

Project coverage is 91.19%. Comparing base (a82069d) to head (e04f552).

Files with missing lines Patch % Lines
chord_metadata_service/restapi/api_renderers.py 84.09% 5 Missing and 2 partials ⚠️
chord_metadata_service/authz/viewset.py 87.87% 2 Missing and 2 partials ⚠️
chord_metadata_service/patients/api_views.py 82.60% 2 Missing and 2 partials ⚠️
chord_metadata_service/authz/permissions.py 83.33% 1 Missing and 1 partial ⚠️
...hord_metadata_service/discovery/scopeable_model.py 96.29% 1 Missing ⚠️
chord_metadata_service/phenopackets/models.py 92.85% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #536      +/-   ##
===========================================
+ Coverage    90.92%   91.19%   +0.26%     
===========================================
  Files          127      129       +2     
  Lines         4895     4995     +100     
  Branches       447      452       +5     
===========================================
+ Hits          4451     4555     +104     
+ Misses         299      292       -7     
- Partials       145      148       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidlougheed
refact: define common top-level (data type model) scope filters
5cac2ff
@davidlougheed
Merge remote-tracking branch 'origin/develop' into refact/scopeable-m…
1fd3ea6 
…odel-base-class

# Conflicts:
#	chord_metadata_service/phenopackets/api_views.py
@davidlougheed
refact(discovery): constant for instance ValidatedDiscoveryScope
8bcff91
@davidlougheed
chore(discovery): allow specifying data type for authz repr of scope
843cabf
@davidlougheed
refact: start working on auth systems for model viewsets
a60a418
@davidlougheed
chore: remove authorized dataset filters (CanDIG legacy code)
827bd4f
@davidlougheed
fix: proper permissions for schema endpoints
c811bbd
@davidlougheed
more work on scoped models
65cc1f7
@davidlougheed
Merge remote-tracking branch 'origin/develop' into refact/scopeable-m…
275524a 
…odel-base-class

# Conflicts:
#	chord_metadata_service/chord/tests/test_api.py
#	chord_metadata_service/discovery/api_views.py
#	chord_metadata_service/discovery/utils.py
#	chord_metadata_service/experiments/api_views.py
#	chord_metadata_service/phenopackets/api_views.py
@davidlougheed
test: work on tests
c07b471
@davidlougheed
fix(phenopackets): issues with biosample batch / csv rendering
cc1235e
@davidlougheed
chore(patients): enable authz for individuals API
43f0c3f
@davidlougheed
more authz functionality impl
0368ad7 
test: add more tests / fix test issues
@davidlougheed
fix!: only enable GET/POST list endpoints (biosample batch viewset)
a21afde
@davidlougheed
test: individual phenopackets responses
1d884dd
@davidlougheed
refact: authz fn name change
8af3867
@davidlougheed
refact(restapi): create base class for Bento CSV renderers
d435acd
@davidlougheed
chore: allow override of checked permission for POST-query-data reqs
3b3b991
@davidlougheed
chore: cache scope for repeated request scope gets
7068623
@davidlougheed
test: fix forbidden phenopackets attachment test
f5dc770
@davidlougheed
refact: create authz base modelviewset
a90b779
@davidlougheed
add TODOs
44f1031
@davidlougheed
Merge remote-tracking branch 'origin/develop' into refact/scopeable-m…
44427c1 
…odel-base-class
@davidlougheed davidlougheed changed the title [WIP] refact: define a "scopeable model" base class + modelviewset scoping refact: define a "scopeable model" base class + modelviewset scoping Nov 27, 2024
@davidlougheed davidlougheed changed the title refact: define a "scopeable model" base class + modelviewset scoping refact!: define a "scopeable model" base class + modelviewset scoping Nov 27, 2024
@davidlougheed
Copy link
Member Author

@v-rocheleau this is still WIP, but I would like to know your thoughts on the general approach/abstractions chosen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v-rocheleau v-rocheleau Awaiting requested review from v-rocheleau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@davidlougheed